Skip to content

Conversation

@ahans
Copy link
Contributor

@ahans ahans commented May 10, 2025

As discussed here.

[no important files changed]

Copy link
Contributor

@marcelweikum marcelweikum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
I think you forgot to remove the #endif of the "Classes and Headers" topic in the Markdown files below:

concepts/headers/about.md

concepts/headers/introduction.dm

exercises/concept/doctor-data/.docs/introduction.md

Otherwise looks good!

@ahans
Copy link
Contributor Author

ahans commented May 11, 2025

Hey, I think you forgot to remove the #endif of the "Classes and Headers" topic in the Markdown files below:

concepts/headers/about.md

concepts/headers/introduction.dm

exercises/concept/doctor-data/.docs/introduction.md

Otherwise looks good!

Thanks, good catch! Looking at those files again, I realized I actually should not have changed those at all, since they introduce the different ways of using include guards. This also made me look at more md files and I realized there are quite a few more that used a different style of include guards also. I now reverted the changes to those that should include both styles and included changes to the other markdown files.

Copy link
Contributor

@marcelweikum marcelweikum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@ahans ahans requested review from siebenschlaefer and vaeng May 12, 2025 07:04
@vaeng
Copy link
Contributor

vaeng commented May 12, 2025

Hey, I think you forgot to remove the #endif of the "Classes and Headers" topic in the Markdown files below:

concepts/headers/about.md

concepts/headers/introduction.dm

exercises/concept/doctor-data/.docs/introduction.md

Otherwise looks good!

Thanks, good catch! Looking at those files again, I realized I actually should not have changed those at all, since they introduce the different ways of using include guards. This also made me look at more md files and I realized there are quite a few more that used a different style of include guards also. I now reverted the changes to those that should include both styles and included changes to the other markdown files.

Thanks for checking. We need to talk about the different styles in the syllabus, so these should stay.

[no important files changed]
@ahans ahans force-pushed the ahans/unify-include-guards branch from 7b55201 to a53414c Compare May 12, 2025 07:27
@ahans ahans merged commit 8ef5867 into exercism:main May 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants