Skip to content

Conversation

@miguelmarcondesf
Copy link

Hello, I think we have two uses of REQUIRE where it's not necessary due to functions that can not be evaluated by it.

Hello, I think we have two uses of `REQUIRE` where it's not necessary due to functions that can not be evaluated by it.
@github-actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this May 18, 2025
@ahans
Copy link
Contributor

ahans commented May 19, 2025

The instructions clearly state that both methods, hit() as well as teleport, should return true, so it's appropriate to check for that in the tests.

@miguelmarcondesf
Copy link
Author

The instructions clearly state that both methods, hit() as well as teleport, should return true, so it's appropriate to check for that in the tests.

Thank you @ahans for answering that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants