docs: remove submitting incomplete solutions from README#1245
Merged
robkeim merged 1 commit intoexercism:masterfrom Mar 8, 2019
ErikSchierboom:remove-submit-incomplete
Merged
docs: remove submitting incomplete solutions from README#1245robkeim merged 1 commit intoexercism:masterfrom ErikSchierboom:remove-submit-incomplete
robkeim merged 1 commit intoexercism:masterfrom
ErikSchierboom:remove-submit-incomplete
Conversation
robkeim
approved these changes
Mar 8, 2019
Contributor
|
It's too bad the patch solution doesn't work anymore, but thanks for doing this! 👍 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unhelpful "You can submit incomplete solutions" part of the README. While doing this, I found that the Git patch solution did not work anymore. I also found it to interfere with updating a single exercise, which is why I've removed said functionality in this PR. We lose a little bit in the process (function is no longer renamed to method), but I'm okay with that.