bracket-push: rename to matching-brackets#1276
Merged
ErikSchierboom merged 2 commits intoexercism:masterfrom Apr 15, 2019
Merged
bracket-push: rename to matching-brackets#1276ErikSchierboom merged 2 commits intoexercism:masterfrom
ErikSchierboom merged 2 commits intoexercism:masterfrom
Conversation
This rename was proposed in: exercism/problem-specifications#1501 The rationale for the name is: * to name the exercise by its story, not by what it potentially teaches * to avoid unnecessarily biasing the solution space
ErikSchierboom
requested changes
Apr 15, 2019
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
Looking good! Just one missed rename: the solution file's project reference.
See https://github.com/exercism/csharp/blob/master/exercises/Exercises.sln#L33
ErikSchierboom
approved these changes
Apr 15, 2019
Member
|
Merged. Thanks @SleeplessByte ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rename was proposed in:
exercism/problem-specifications#1501
The rationale for the name is: