WIP Update prime factors to use longs#1310
Conversation
|
@robkeim You're not really doing anything wrong, it's just that JSON.net by default will deserialize numbers to a Now what to do about this. There are several options I feel:
I think the second one is a little bit nicer, but also a bit more work. I'm happy to help here though. What do you think? |
|
I'm also in favor of the second solution. I poked around a bit and tried to understand how the deserialization works, but I don't see where/how we can add a custom JsonConverter to parse integer values correctly. I'm not sure what's the best way to proceed here. Did you want to try to make the change or did you want to try to explain to me where the change needs to be made and then have me do it? Either way works for me. |
I think this is probably the easiest option. I'll let you know when I have anything for you to work with! |
|
Sounds good, if there's anything I can do let me know! |
|
Great thanks @ErikSchierboom! I'll go ahead and close PR and review the other one. |
slight amendment to wording, sorry if these are annoying!
slight amendment to wording, sorry if these are annoying!
slight amendment to wording, sorry if these are annoying!
slight amendment to wording, sorry if these are annoying!
slight amendment to wording, sorry if these are annoying!
This change causes all of the ints to be treated as longs throughout the rest of the exercises. I left the other exercises out of this WIP PR so it makes it easier to see what changes I made.
@ErikSchierboom do you have an idea what I'm doing wrong?
Fixes #1309