Skip to content

Update canonical data to latest version#1314

Merged
ErikSchierboom merged 1 commit intoexercism:masterfrom
robkeim:update-canonical-data
Sep 5, 2019
Merged

Update canonical data to latest version#1314
ErikSchierboom merged 1 commit intoexercism:masterfrom
robkeim:update-canonical-data

Conversation

@robkeim
Copy link
Copy Markdown
Contributor

@robkeim robkeim commented Sep 1, 2019

No description provided.

@robkeim
Copy link
Copy Markdown
Contributor Author

robkeim commented Sep 1, 2019

Looks like a legitimate failure that needs to be addressed.

Comment thread exercises/matrix/MatrixTest.cs Outdated
{
var sut = new Matrix("1 2 3\n4 5 6\n7 8 9\n8 7 6");
Assert.Equal(new[] { 3, 6, 9, 6 }, sut.Column(3));
var sut = new Matrix("1 2 3 4\n 5 6 7 8\n 9 8 7 6");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is the extra space after the 4\n part. Looks like a possible problem with the canonical data.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robkeim robkeim force-pushed the update-canonical-data branch from 219cd68 to 05ccfd3 Compare September 4, 2019 20:07
@ErikSchierboom
Copy link
Copy Markdown
Member

Once again, thanks for fixing this @robkeim!

@ErikSchierboom ErikSchierboom merged commit 6850035 into exercism:master Sep 5, 2019
@robkeim robkeim deleted the update-canonical-data branch November 8, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants