Added static keyword to static classes#215
Merged
ErikSchierboom merged 2 commits intoexercism:dotnet-corefrom Feb 28, 2017
Merged
Added static keyword to static classes#215ErikSchierboom merged 2 commits intoexercism:dotnet-corefrom
ErikSchierboom merged 2 commits intoexercism:dotnet-corefrom
Conversation
ErikSchierboom
requested changes
Feb 28, 2017
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
Looking great! Would you mind also changing the example implementations (in the Example.cs file) for those problems to also use static classes?
Contributor
Author
|
@ErikSchierboom Done with changes. |
ErikSchierboom
approved these changes
Feb 28, 2017
Member
|
Thanks a lot @tushartyagi! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following 5 exercises had only
staticmethods but the classes were notstatic. Changes for the same.Targets #207