Use Assert.Null when validating against null#359
Merged
robkeim merged 2 commits intoexercism:masterfrom Aug 19, 2017
Merged
Conversation
robkeim
reviewed
Aug 19, 2017
| return new TestMethodBodyWithBooleanCheck(canonicalDataCase, CanonicalData); | ||
| } | ||
|
|
||
| if(canonicalDataCase.Expected is null) |
Contributor
There was a problem hiding this comment.
The Type A in me is screaming about a missing space after the if ;)
Contributor
There was a problem hiding this comment.
I forgot that I can fix it inline :)
Contributor
Author
There was a problem hiding this comment.
Oh man, that would bother me too. I didn't even notice that. Usually Visual Studio just automatically tosses that in for me.
Contributor
|
Nice work @jpreese! The only thing I wonder about this is should we be avoiding |
Contributor
|
Thanks @jpreese 🎉 |
Member
👍 I think we should definitely have some discussion on this issue. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #356