Implement isbn-verifier exercise#485
Merged
ErikSchierboom merged 2 commits intoexercism:masterfrom Nov 10, 2017
Merged
Conversation
* Added example code * Added test generator plus tests * Added entry in config.json
ErikSchierboom
requested changes
Nov 9, 2017
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
Just one small nit, other than that this is brilliant!
| { | ||
| protected override void UpdateCanonicalData(CanonicalData canonicalData) | ||
| { | ||
| canonicalData.Exercise = "Isbn"; |
Member
There was a problem hiding this comment.
In general, I would like to conform to the canonical data. Could you remove this line? This will cause the Isbn class to be renamed to IsbnVerifier, which still makes sense to me (and matches the file name).
| canonicalData.Exercise = "Isbn"; | ||
| foreach (var canonicalDataCase in canonicalData.Cases) | ||
| { | ||
| canonicalDataCase.Property = "IsValid"; |
Member
There was a problem hiding this comment.
Much better than the existing property! In fact, I've gone and submitted a PR to change the canonical data.
Contributor
Author
|
@ErikSchierboom, thanks for the review! |
ErikSchierboom
approved these changes
Nov 10, 2017
Member
|
Merged! Thanks a lot! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #484
Please let me know if there's anything I'm missing! Thanks!