Skip to content

Update exercises to the latest canonical data#487

Merged
ErikSchierboom merged 6 commits intoexercism:masterfrom
robkeim:update-exercises
Nov 12, 2017
Merged

Update exercises to the latest canonical data#487
ErikSchierboom merged 6 commits intoexercism:masterfrom
robkeim:update-exercises

Conversation

@robkeim
Copy link
Copy Markdown
Contributor

@robkeim robkeim commented Nov 12, 2017

I just ran the generator and it looks like there have been a fair amount of changes to canonical data that we haven't integrated yet. This batch contains the "trivial changes" requiring no updates to the code. The remaining exercises will require some updates.

@ErikSchierboom
Copy link
Copy Markdown
Member

Great work! I'll wait for the CI to become green.

@robkeim
Copy link
Copy Markdown
Contributor Author

robkeim commented Nov 12, 2017

I updated a few more tests that required minor changes as well. The following tests are still out-of-date and need to be updated:

  • AllYourBase (changed to using "error" structure)
  • BeerSong (changed to returning an array which isn't currently being formatted multi-line. That means the test validating the entire song is a reaaalllllyyyyy long line :) )
  • NthPrime (changed to using "error" structure)

@ErikSchierboom ErikSchierboom merged commit b27879a into exercism:master Nov 12, 2017
@ErikSchierboom
Copy link
Copy Markdown
Member

Thanks a lot! 🎉 Do you want to create separate issues for the out-of-date exercises?

@robkeim robkeim deleted the update-exercises branch November 12, 2017 13:28
@robkeim
Copy link
Copy Markdown
Contributor Author

robkeim commented Nov 12, 2017

Sounds good @ErikSchierboom let's keep track of those updates in #488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants