Skip to content

Add back deleted, deprecated exercises#503

Merged
ErikSchierboom merged 1 commit intomasterfrom
kytrinyx/missing-deprecated
Dec 31, 2017
Merged

Add back deleted, deprecated exercises#503
ErikSchierboom merged 1 commit intomasterfrom
kytrinyx/missing-deprecated

Conversation

@kytrinyx
Copy link
Copy Markdown
Member

@kytrinyx kytrinyx commented Dec 30, 2017

When migrating the data from v1 to v2, we will lose all the solutions submitted to
deprecated exercises, unless they exist in the track configuration.

This adds the deprecated binary, trinary, octal, and hexadecimal exercises back,
leaving them deprecated so that they don't actively show up as part of the track.

We can delete them from the track again after we launch v2, if we want to.

@ErikSchierboom
Copy link
Copy Markdown
Member

@kytrinyx Do they have to be actually working exercises? As of now, they don't follow the newly introduced project format. That is at the least inconsistent, but possibly also erroneous. Should people that once worked on these exercises be allowed to work on them again?

@iHiD
Copy link
Copy Markdown
Member

iHiD commented Dec 30, 2017

Do they have to be actually working exercises?

Yes in terms of they need the files etc. No in terms of them needing all the same level of config (e.g. topics, difficulty, etc).

I'm 👍 to this @kytrinyx, but let's check it in a sample ETL run to be sure.

@kytrinyx
Copy link
Copy Markdown
Member Author

As of now, they don't follow the newly introduced project format.

Hm. Yeah, they do need to actually work. I'll read through the track documentation and get this to conform.

@kytrinyx kytrinyx force-pushed the kytrinyx/missing-deprecated branch from e7dca94 to b36dbee Compare December 30, 2017 20:39
@kytrinyx
Copy link
Copy Markdown
Member Author

@ErikSchierboom Would you take a look to see if this is properly following the project structure?

@kytrinyx
Copy link
Copy Markdown
Member Author

The build is failing because I've not yet converted the test suite. I'll give that a go next.

@ErikSchierboom
Copy link
Copy Markdown
Member

Thanks for doing this! I'll take a look tomorrow. By the way, you can verify the build by running build.sh or build.cmd (also works for the F# track).

@kytrinyx
Copy link
Copy Markdown
Member Author

you can verify the build by running build.sh or build.cmd (also works for the F# track).

Ah! That's helpful thanks!

@ErikSchierboom
Copy link
Copy Markdown
Member

Oh, and you can test build single exercises using --exercise=

@ErikSchierboom
Copy link
Copy Markdown
Member

That is --exercise=slug

@kytrinyx
Copy link
Copy Markdown
Member Author

Sweet, thanks!

When migrating the data from v1 to v2, we will lose all the solutions submitted to
deprecated exercises, unless they are configured.

This adds the deprecated binary, trinary, octal, and hexadecimal exercises back,
leaving them deprecated so that they don't actively show up as part of the track.
@kytrinyx kytrinyx force-pushed the kytrinyx/missing-deprecated branch from b36dbee to 667080e Compare December 30, 2017 22:20
@ErikSchierboom ErikSchierboom merged commit 3784df0 into master Dec 31, 2017
@ErikSchierboom ErikSchierboom deleted the kytrinyx/missing-deprecated branch December 31, 2017 08:15
@ErikSchierboom
Copy link
Copy Markdown
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants