Add Fake build script#51
Merged
jwood803 merged 1 commit intoexercism:masterfrom Feb 10, 2016
ErikSchierboom:fake-build
Merged
Conversation
Contributor
|
Nice! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Fake build script that allows all tests to run against the example implementations.
In the process, I immediately benefitted from having these automatic tests: the
LargestSeriesProductTestclass contained an incorrect test (parameterized test which was not defined as such).Furthermore, the tests for the crypto-square exercise failed. This turned out to be both an implementation issue as well as test for the wrong expected values. For the correct expected values, I check several other language tracks, including the Haskell and Clojure tracks, which both had the same expected value that our test did not have.