Skip to content

Inline the track-wide exercise README insert into the exercise template#519

Merged
ErikSchierboom merged 6 commits intomasterfrom
kytrinyx/inline-insert
Feb 5, 2018
Merged

Inline the track-wide exercise README insert into the exercise template#519
ErikSchierboom merged 6 commits intomasterfrom
kytrinyx/inline-insert

Conversation

@kytrinyx
Copy link
Copy Markdown
Member

@kytrinyx kytrinyx commented Feb 4, 2018

Since we now have a track-wide exercise template, I've inlined the markdown README insert in the docs directory into the template.

The first three commits do general cleanup so that the diff when inlining is minimal.

After inlining, I've got a commit that tweaks the inlined text to make it refer to the actual exercise directory name, since the template has access to that value at generation time.

The final commit regenerates all the READMEs using the updated template.

See exercism/meta#94

Katrina Owen added 6 commits February 4, 2018 12:50
The upstream problem specifications have gotten a number of formatting and whitespace tweaks, as well as
some clarifications to the description text.

This regenerates all the exercise READMEs to pull in upstream changes.
Now that we have a track-wide template, we can get rid of the docs insert.
Since the template can refer to exercise-specific values, this updates the
track-wide submission hint to use the actual name of the exercise directory.

It also removes the example submit command, which seems redundant now.
@ErikSchierboom ErikSchierboom merged commit 152c8ca into master Feb 5, 2018
@ErikSchierboom
Copy link
Copy Markdown
Member

Looking good! We as the C# track's maintainers could have a discussion to determine if the track-specific bit about the submit directory adds any real value. @robkeim @jpreese what do you think?

@ErikSchierboom ErikSchierboom deleted the kytrinyx/inline-insert branch February 5, 2018 10:03
@robkeim
Copy link
Copy Markdown
Contributor

robkeim commented Feb 6, 2018

Thanks @kytrinyx! @ErikSchierboom I'm not sure how much additional value that submit directory is adding and if we felt there was a lot of value add I'd argue we should try to get it integrated for all of the tracks. What are your thoughts?

@ErikSchierboom
Copy link
Copy Markdown
Member

I don't think it adds much value. Personally, I'm in favor of just removing it. The Exercism CLI should actually help the user with these kinds of errors I feel.

@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 7, 2018

The Exercism CLI should actually help the user with these kinds of errors I feel.

Agreed! I'll remove it and push this back up.

@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 7, 2018

Oh. Didn't realize this was merged. I'll submit a new PR :)

@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 7, 2018

Actually, I'll let you all sort it out now that I think of it. Sorry for the noise 🌷

@ErikSchierboom
Copy link
Copy Markdown
Member

@kytrinyx One question: is there a tool with which we can regenerate the docs?

@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 7, 2018

is there a tool with which we can regenerate the docs?

Shoot, yes! 100% absolutely yes :)

TL;DR:

configlet generate . --spec-path=../path/to/problem-specifications

Long version:
https://github.com/exercism/docs/blob/master/maintaining-a-track/regenerating-exercise-readmes.md

@ErikSchierboom
Copy link
Copy Markdown
Member

Wonderful, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants