Skip to content

docs: Update documentation#615

Merged
jpreese merged 2 commits intoexercism:masterfrom
ErikSchierboom:update-docs
Aug 7, 2018
Merged

docs: Update documentation#615
jpreese merged 2 commits intoexercism:masterfrom
ErikSchierboom:update-docs

Conversation

@ErikSchierboom
Copy link
Copy Markdown
Member

No description provided.

@ErikSchierboom
Copy link
Copy Markdown
Member Author

This PR adds both a general running the tests section, as well as links to the additional resources.

Copy link
Copy Markdown
Contributor

@jpreese jpreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixes

Comment thread docs/RESOURCES.md Outdated
* [\@dotnet](https://twitter.com/DotNet) is the official .NET Twitter account.
* [Gitter](https://gitter.im/exercism/xcsharp) is the C# Gitter room, go here to get support and ask questions related to the C# track.

- [StackOverflow ](http://stackoverflow.com/questions/tagged/c%23) can be used to search for your problem and see if it has been answered already. You can also ask and answer questions.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space in the tag

Comment thread exercises/clock/README.md
## Hints
This exercise requires you to implements a type-specific method for determining equality of instances.
For more information, see [this page]
(https://docs.microsoft.com/en-us/dotnet/core/api/System.IEquatable-1) .
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after period

Comment thread exercises/clock/README.md Outdated
Two clocks that represent the same time should be equal to each other.

## Hints
This exercise requires you to implements a type-specific method for determining equality of instances.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implement*

- **Rule 1**: If a word begins with a vowel sound, add an "ay" sound to the end of the word. Please note that "xr" and "yt" at the beginning of a word make vowel sounds (e.g. "xray" -> "xrayay", "yttria" -> "yttriaay").
- **Rule 2**: If a word begins with a consonant sound, move it to the end of the word and then add an "ay" sound to the end of the word. Consonant sounds can be made up of multiple consonants, a.k.a. a consonant cluster (e.g. "chair" -> "airchay").
- **Rule 3**: If a word starts with a consonant sound followed by "qu", move it to the end of the word, and then add an "ay" sound to the end of the word (e.g. "square" -> "aresquay").
- **Rule 4**: If a word contains a "y" after a consonant cluster or as the second letter in a two letter word it makes a vowel sound (e.g. "rhythm" -> "ythmrhay", "my" -> "ymay").
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sentence seems a little confusing.. "..cluster or as the second letter..."

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create this as an issue at the problem-specifications repo?

No Sharps or Flats:
C major
A minor
a minor
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this be left as capital?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create this as an issue at the problem-specifications repo?

@ErikSchierboom
Copy link
Copy Markdown
Member Author

@jpreese Thanks for the review! I've updated the PR (please squash before merging please).

@jpreese
Copy link
Copy Markdown
Contributor

jpreese commented Aug 7, 2018

Looks like a test failed, rerunning build to double check.

@jpreese jpreese merged commit ae18b13 into exercism:master Aug 7, 2018
@ErikSchierboom
Copy link
Copy Markdown
Member Author

Thanks!

@ErikSchierboom ErikSchierboom deleted the update-docs branch August 7, 2018 14:49
@jpreese
Copy link
Copy Markdown
Contributor

jpreese commented Aug 7, 2018

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants