Skip to content

Updates the README files for various exercises#696

Merged
ErikSchierboom merged 2 commits intoexercism:masterfrom
Zureka:feature/update-readmes
Oct 12, 2018
Merged

Updates the README files for various exercises#696
ErikSchierboom merged 2 commits intoexercism:masterfrom
Zureka:feature/update-readmes

Conversation

@Zureka
Copy link
Copy Markdown
Contributor

@Zureka Zureka commented Oct 10, 2018

Ran the update-docs.sh script to update the README files and apply any patches that were necessary.

Ran the `update-docs.sh` script to update the README files and apply any
patches that were necessary.
@Zureka
Copy link
Copy Markdown
Contributor Author

Zureka commented Oct 10, 2018

@ErikSchierboom I changed my mind, a batch of README updates is just easier. Having individual PR's for each would just be too much overhead.


To run the tests, run the command `dotnet test` from within the exercise directory.

### Laziness test
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd. I would have expected this patch to be included. Would you mind looking into why this patch did not get included?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the patch failed to apply. Updating the docs with the update-docs.sh script removes the Laziness test section entirely and that patch file only updates the wording of that section. I'll see what I can do to update that patch file for the change to be applied correctly.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Zureka
Copy link
Copy Markdown
Contributor Author

Zureka commented Oct 12, 2018

@ErikSchierboom The patch file should be fixed now.

@Zureka
Copy link
Copy Markdown
Contributor Author

Zureka commented Oct 12, 2018

It looks like there have been updates to master since this branch was created. Do you have a preferred rebase strategy you would like me to follow or would just merging this branch into master as is be sufficient?

@ErikSchierboom ErikSchierboom merged commit 63ed0c1 into exercism:master Oct 12, 2018
@ErikSchierboom
Copy link
Copy Markdown
Member

I can just squash and merge from the GitHub GUI, which I just did. Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants