Remind learners to remove Skip properties from tests (in Leap)#726
Remind learners to remove Skip properties from tests (in Leap)#726ErikSchierboom merged 7 commits intoexercism:masterfrom
Conversation
ErikSchierboom
left a comment
There was a problem hiding this comment.
Hi! Thanks a lot for this PR. Directly editing the README is unfortunately not the way to go, as the README files are re-generated automatically from time to time. That said, I think the message itself is actually incredibly useful, and I think we could just include it in every single README.
To update the general README, you should edit the config/exercise_readme.go.tmpl file. Once this file has been edited, you can the re-generate the documentation using the update-docs.sh command in the root (we still have to create a Windows version of that script).
What do you think about this approach?
If you feel this is a good idea, you could then also remove the last bit in the template on "Submitting Incomplete Solutions", which is still a leftover from the previous version.
|
@ErikSchierboom That makes sense, and I'll try to get to that soon. |
|
@ErikSchierboom I've updated the template file, but unfortunately lack a linux machine to run the shell script from. I tried using git bash, and got the following error from the Not sure what to do with the pull request at this point. |
ErikSchierboom
left a comment
There was a problem hiding this comment.
I've left two small notes.
Regarding the re-generating of the documentation, I'll try and add a script that can run on Windows this weekend.
|
This is a good PR, please complete this one as many beginners are tripping up on this issue. Just as tip for another method to do Linux scripts if you have Windows 10 is to install the Windows Subsystem for Linux and I often use it for running bash scripts. |
|
@j2jensen Are you still interested in working on this PR? |
Also combined the two "Notes" sections under one header.
… attributes from the tests.
|
Yes, I'm working on it. Sorry it's been a while. |
Co-Authored-By: j2jensen <j2jensen@users.noreply.github.com>
2720721 to
443cdff
Compare
Co-Authored-By: j2jensen <j2jensen@users.noreply.github.com>
|
All right, I think I've got it. @ErikSchierboom can you let me know if there are any other changes I need to make? |
|
This is looking great! I think this will really help a lot of students. Thanks so much for doing this! |
Also combined the two "Notes" sections under one header.