734 use decimal for money#737
Merged
ErikSchierboom merged 8 commits intoexercism:masterfrom Dec 17, 2018
AndrewYHuang:734-use-decimal-for-money
Merged
734 use decimal for money#737ErikSchierboom merged 8 commits intoexercism:masterfrom AndrewYHuang:734-use-decimal-for-money
ErikSchierboom merged 8 commits intoexercism:masterfrom
AndrewYHuang:734-use-decimal-for-money
Conversation
added 4 commits
December 17, 2018 16:06
ErikSchierboom
requested changes
Dec 17, 2018
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
Great work! Some small nits.
Contributor
Author
|
Regarding lines 942-971 of the ci log, does the example implementation need updating? c# really doesn't like doing equals(decimal, float) |
Member
It does indeed. |
Contributor
Author
|
Made all the requested changes: Updated examples and added that blank line to RenderNumber |
ErikSchierboom
approved these changes
Dec 17, 2018
Member
|
Merged! This is great work. Thanks a lot for doing this. 🎉 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated BankAccount, BookStore and Ledger exercises to use decimal for money instead of float or double.
Updated RenderNumber and Render with decimal rendering.
Updated BookStore test generator to use decimal literals for BookStore tests.