Skip to content

Specify that tests must be output in order#10

Merged
iHiD merged 3 commits intomasterfrom
iHiD-patch-4
Jan 6, 2021
Merged

Specify that tests must be output in order#10
iHiD merged 3 commits intomasterfrom
iHiD-patch-4

Conversation

@iHiD
Copy link
Copy Markdown
Member

@iHiD iHiD commented Jan 5, 2021

In the Research Site, the responsibly of ordering the tests lay with the website. It used the config.json file as its basis for ordering. Now that file has been deprecated, the responsibility for ordering moves to the individual test-runners.

I can't see a situation where a test-runner can't achieve this by reordering the tests based on grepping the file, but if anyone finds one, we can work out how to deal with it then.

In the Research Site, the responsibly of ordering the tests lay with the website. It used the `config.json` file as its basis for ordering. Now that file has been deprecated, the responsibility for ordering moves to the individual test-runners.
@iHiD iHiD requested a review from ErikSchierboom January 5, 2021 16:37
@SleeplessByte
Copy link
Copy Markdown
Member

If your track only supports randomly-ordered test runs, use a stable seed (for example 42), if you want a "quick fix", before spending time to re-order the output.

My proposal to re-order the output is literally doing that. When you have the results of the tests, order them based on the entry in the test file. You can use AST for that, but you can also use test-matches (and order by index).

Comment thread anatomy/track-tooling/test-runners/interface.md
@SleeplessByte
Copy link
Copy Markdown
Member

SleeplessByte commented Jan 5, 2021

I would rename this PR to output in order, not run.

edit: haha that edit was literal. nice yoda grammar

@iHiD iHiD changed the title Specify that tests must be run in order Specify that tests must be output in order Jan 5, 2021
Co-authored-by: Jeremy Walker <jez.walker@gmail.com>
Comment thread anatomy/track-tooling/test-runners/interface.md Outdated
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants