Skip to content

Update: flatten-array add additional test cases#1060

Merged
angelikatyborska merged 1 commit intoexercism:mainfrom
kwchang0831:problem-specifications-1953-additional-test-cases
Feb 7, 2022
Merged

Update: flatten-array add additional test cases#1060
angelikatyborska merged 1 commit intoexercism:mainfrom
kwchang0831:problem-specifications-1953-additional-test-cases

Conversation

@kwchang0831
Copy link
Copy Markdown
Contributor

problem-specifications #1953

Implements the additional test cases.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2022

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

Copy link
Copy Markdown
Member

@angelikatyborska angelikatyborska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thank you!

@angelikatyborska angelikatyborska merged commit 7604ab5 into exercism:main Feb 7, 2022
@kwchang0831 kwchang0831 deleted the problem-specifications-1953-additional-test-cases branch February 7, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants