Fix compiler warnings when running mix test#227
Merged
parkerl merged 1 commit intoexercism:masterfrom Aug 21, 2016
Merged
Conversation
When we ran `mix test` we were getting several compiler warnings. Here's the ouput that we got before this PR: ``` warning: behaviour Set undefined exercises/custom-set/example.exs:1 warning: the Inspect protocol has already been consolidated, an implementation for CustomSet has no effect exercises/custom-set/example.exs:126 warning: function digits/1 is private, @doc's are always discarded for private functions exercises/largest-series-product/example.exs:3 warning: function slices/2 is private, @doc's are always discarded for private functions exercises/largest-series-product/example.exs:17 warning: redefining module DNA (current version defined in memory) exercises/nucleotide-count/example.exs:1 warning: redefining module DNA (current version defined in memory) exercises/rna-transcription/example.exs:1 Including tags: [:pending] warning: redefining module ChangeTest (current version defined in memory) exercises/flatten-array/flatten_array_test.exs:8 warning: redefining module ChangeTest (current version defined in memory) exercises/hexadecimal/hexadecimal_test.exs:8 warning: redefining module DNATest (current version defined in memory) exercises/nucleotide-count/nucleotide_count_test.exs:8 warning: redefining module DNATest (current version defined in memory) exercises/rna-transcription/rna_transcription_test.exs:8 warning: the Inspect protocol has already been consolidated, an implementation for BinTree has no effect exercises/zipper/zipper_test.exs:16 ``` I addressed all of the warnings except those for `CustomSet` since those warnings are taken care of in exercism#226. Many of them were naming issues for modules, and funny enough this fix of the compiler warnings pointed out that we had a typo in a test that should have failed but wasn't failing! I've also fixed that typo.
Contributor
|
Awesome!!! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we ran
mix testwe were getting several compiler warnings. Here's theouput that we got before this PR:
I addressed all of the warnings except those for
CustomSetsince thosewarnings are taken care of in #226. Many of them were naming issues for
modules, and funny enough this fix of the compiler warnings pointed out that we
had a typo in a test that should have failed but wasn't failing! I've also
fixed that typo.