Skip to content

replace 'problems' key with 'exercises' in config.json#122

Merged
NobbZ merged 2 commits intoexercism:masterfrom
cgrayson:config-update
Oct 18, 2016
Merged

replace 'problems' key with 'exercises' in config.json#122
NobbZ merged 2 commits intoexercism:masterfrom
cgrayson:config-update

Conversation

@cgrayson
Copy link
Copy Markdown
Contributor

see #108

@cgrayson
Copy link
Copy Markdown
Contributor Author

I forgot to point out that as of exercism/x-api#137, it is safe to remove problems.

Copy link
Copy Markdown
Member

@NobbZ NobbZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate if you put the keys for each exercise in the following order:

  • slug
  • topics
  • difficulty

Also I prefer to have the active exercises listed before the inactive ones, so it would be nice if you move exercises at the location that was prviously occupied by the problems key.

After that I think we are ready to merge this one as a base for the re-evaluation done in #107. Thanks for your effort so far.

Please do also add a FIXES-note in your commit-message or PR description.

@NobbZ NobbZ added this to the 2016 Overhaul milestone Oct 17, 2016
@cgrayson
Copy link
Copy Markdown
Contributor Author

Changes made.

Please do also add a FIXES-note in your commit-message or PR description.

I didn't include a FIXES note previously because this PR only addresses the first of 3 items listed in #108, but without updating difficulty beyond a default of "1" or adding anything in topics. But I can add "fixes…" when I squash these commits, if you want me to.

@NobbZ
Copy link
Copy Markdown
Member

NobbZ commented Oct 18, 2016

Of course you are right on steps 2 and 3 of #108, I didn't realize them when glancing over the ticket.

@NobbZ NobbZ merged commit 25a403f into exercism:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants