luhn: update tests. fixes #435#437
Merged
robphoenix merged 3 commits intoexercism:masterfrom Jan 13, 2017
Merged
Conversation
added 3 commits
January 12, 2017 11:12
Due to previous commits updating the tests a test version has been added
petertseng
approved these changes
Jan 13, 2017
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
yup, seems good.
Under a preference that at every single commit, the build should be passing, I would suggest that when merging the commits be squashed, or reordered so the len(n) == 1 change to the example comes before the new test cases (the removal of AddCheck might have to come after, sorry). I suppose it's not a hard requirement, but I keep in the habit in case I ever need to git-bisect or something...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
original PR instigating the changes: exercism/problem-specifications#474