space-age: do not force rounding of solutions#960
Merged
ferhatelmas merged 2 commits intoexercism:masterfrom Nov 15, 2017
Merged
space-age: do not force rounding of solutions#960ferhatelmas merged 2 commits intoexercism:masterfrom
ferhatelmas merged 2 commits intoexercism:masterfrom
Conversation
The expected age values are specified (in respective canonical-data.json) with 2-digit precision (e.g., 31.69), while the actual result is a float. Instead of forcing the solution to perform an arbitrary rounding, the test code verifies the result with certain precision (currently same 2-digit, for compatibility - can be eventually added to canonical-data.json itself). Aligned with the conclusion of the discussion in exercism/problem-specifications#880
ferhatelmas
approved these changes
Nov 15, 2017
Contributor
ferhatelmas
left a comment
ferhatelmas
left a comment
There was a problem hiding this comment.
Never compare floats directly 👍
Member
|
This is funny. I just did the exercise an hour or so ago and was incredibly frustrated about the need to round! Good on you @glikson! |
Contributor
Author
|
@tleen same here - was frustrating enough to actually go and fix it :-) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected age values are specified (in respective canonical-data.json) with 2-digit precision (e.g., 31.69), while the actual result is a float.
Instead of forcing the solution to perform an arbitrary rounding, the test code verifies the result with certain precision (currently same 2-digit, for compatibility - can be eventually added to canonical-data.json itself).
Aligned with the conclusion of the discussion in exercism/problem-specifications#880