Transform exercises in Stack projects - Phase 4 - Migrating all exercises - Part 1#189
Transform exercises in Stack projects - Phase 4 - Migrating all exercises - Part 1#189rbasso merged 2 commits intoexercism:masterfrom rbasso:transform-exercises-in-stack-projects-phase-4-part-1
Conversation
|
I feel I should say real quick that here and in |
|
|
||
| isPythagorean = undefined | ||
|
|
||
| mkTriplet =undefined |
There was a problem hiding this comment.
probably good to add extra space after =, consistency
|
Thank you for the review! I will fix it, but merging will probably be delayed until we finish Phase 2 (Online testing |
| exposed-modules: Sieve | ||
| source-dirs: src | ||
| dependencies: | ||
| - vector |
There was a problem hiding this comment.
This leads me to see an interesting point! (This may apply to exercises other than sieve as well)
This vector is here because the example solution uses it, right? It is not necessarily the case that every submitted solution will use it.
Are we OK with leaving them in here?
Then again, the alternative is to have some custom thing that splices in the example solution's dependencies when we go to Travis, which is not necessarily something we want to tackle.
So our answer might be "We're OK with it", as long as students don't think their solution must use vector.
My personal answer is probably to keep it as is for now, see whether any problems come up
There was a problem hiding this comment.
This is a problem for which I have no good answer. Maybe this will force us to give more attention to the example solutions, as they will define the packages available by default.
It's a design flaw. My bad! 😁
Edit: If it turns out to be a big problem, we can have an example.yaml just for travis, but that would be ugly.
- nth-prime - palindrome-products - pascals-triangle - pig-latin - pythagorean-triplet - saddle-points - say - secret-handshake - series - sieve - simple-cipher - connect - parallel-letter-frequency - sgf-parsing - go-counting - zipper - forth - lens-person Fix comment in `exercises/pov/package.yaml`
Add incomplete stub solutions: - nth-prime - pythagorean-triplet - saddle-points - say - secret-handshake - series - sieve Add stub solutions based on test suite analysis: - connect - pascals-triangle - pig-latin - simple-cipher Add stub solutions based on test instructions: - go-counting - palindrome-products - parallel-letter-frequency - sgf-parsing Update stub solutions to allow compilation: - lens-person
2 participants
Transform exercises in Stack projects #185.
Phase 4 - Migrating all exercises - Part 1
Migrate to stack projects:
Fix comment in
exercises/pov/package.yaml.Add incomplete stub solutions:
Add stub solutions based on test suite analysis:
Add stub solutions based on test instructions:
Update stub solutions to allow compilation: