word-count: Generalize test suite.#403
Merged
petertseng merged 1 commit intoexercism:masterfrom Oct 21, 2016
rbasso:word-count-generalize
Merged
word-count: Generalize test suite.#403petertseng merged 1 commit intoexercism:masterfrom rbasso:word-count-generalize
petertseng merged 1 commit intoexercism:masterfrom
rbasso:word-count-generalize
Conversation
- Generalize the test suite to accept multiple signatures. - Change the test suite to be case insensitive. - Add `HINTS.md` explaining that the test suite is flexible. - Add two example solutions: one very simple; the other with a custom type. - Add the simplest type signature to the stub solution. - Remove unneeded dependencies from `package.yaml`. - Remove old example solution.
Member
|
Everything seems good - the only reason I'm not merging myself immediately is to ask this question - do you think we need to address the caching with multiple examples before merging this? This only affects the build time in a limited way - the exercises with multiple examples are always going to be recompiled, right? Or is it more? |
petertseng
approved these changes
Oct 21, 2016
Contributor
Author
|
I think it is safe to merge and enjoy the new functionality, and then we'll see how critical is to fix the caching. 😄 |
Member
|
OK We'll just take both of the multi-example changes and see what happen. |
This was referenced Oct 31, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HINTS.mdexplaining that the test suite is flexible.package.yaml.These changes tries to make this exercise, at the same time, more accessible and deeper. Beginners will probably be able to solve it easily, while more advanced students will be able the craft more elaborated solutions.
Also, we used
shouldMatchListto improve error reporting and we normalize case before comparing, because the output's case is not an essential part of the problem.This PR is very similar to #393, that changed
anagramto be more flexible, and it is also compatible with previously working solutions.