word-count: Add more tests with punctuation#419
Merged
rbasso merged 1 commit intoexercism:masterfrom Nov 8, 2016
petertseng:word-count
Merged
word-count: Add more tests with punctuation#419rbasso merged 1 commit intoexercism:masterfrom petertseng:word-count
rbasso merged 1 commit intoexercism:masterfrom
petertseng:word-count
Conversation
Member
Author
|
Right, All right, I'm probably not going to have time to work on this soon, so if nobody has an idea to deal with the new tests maybe it's better to create an issue |
Member
Author
|
An idea I will work on soon: |
Added in exercism/problem-specifications#403 This bumps up the difficulty from 4 to 5.
Member
Author
|
Okay, here's something that seems to work OK. I really think I should bump difficulty to 5 for this, so I did it. |
rbasso
approved these changes
Nov 8, 2016
Contributor
rbasso
left a comment
rbasso
left a comment
There was a problem hiding this comment.
Seems great! I think it deserves the 5 you gave to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in exercism/problem-specifications#403
discussion before merging:
These new tests seem to raise difficulty slightly because now we need to be sensitive to the difference between
'as an apostrophe versus used as single quotes. I expect the example solution to need fixing, and I might bump the difficulty to 5 based on what I see.