Skip to content

grains: add signatures to stub solution#431

Merged
petertseng merged 1 commit intoexercism:masterfrom
rbasso:grains-add-signatures-to-stub
Nov 11, 2016
Merged

grains: add signatures to stub solution#431
petertseng merged 1 commit intoexercism:masterfrom
rbasso:grains-add-signatures-to-stub

Conversation

@rbasso
Copy link
Copy Markdown
Contributor

@rbasso rbasso commented Nov 11, 2016

Since we changed grains to expect a Maybe in #197, we had two users that opened issues about not being able to compile it: #305 and #430

The test suite seems correct, but users have a hard time trying to infer the correct types based on test suite.

This PR just add the expected type signatures to the stub solution.

@petertseng petertseng merged commit 196a415 into exercism:master Nov 11, 2016
@rbasso rbasso deleted the grains-add-signatures-to-stub branch November 11, 2016 04:47
@rbasso
Copy link
Copy Markdown
Contributor Author

rbasso commented Nov 11, 2016

As time passes I get more convinced that all exercises should obey the following:

  • Have a stub solution
  • Compile and run the tests with the stub solution
  • Fail the first test with the stub solution

Edit:

  • Have variable names in the stub implementation and a body of undefined.

Not sure yet about:

  • Have a HINTS.md file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants