Revert "pov: Add dummy symbolic link (#454)" and "common: Add folder with common exercise's files"#512
Merged
petertseng merged 2 commits intoexercism:masterfrom Mar 31, 2017
petertseng:rm-symlink
Merged
Revert "pov: Add dummy symbolic link (#454)" and "common: Add folder with common exercise's files"#512petertseng merged 2 commits intoexercism:masterfrom petertseng:rm-symlink
petertseng merged 2 commits intoexercism:masterfrom
petertseng:rm-symlink
Conversation
This reverts commit 860ee70. In #442 we expressed the desire to use symlinks to avoid a duplicate stack.yaml in each exercise. However, RubyGems warns that symlinks are not supported on all platforms, and there is a history of making incorrect link targets for relative symlinks (see exercism/DEPRECATED.trackler#13 for some details on that). Worse, because of the incorrect symlink target, Trackler could not list the files of the exercise, which prevented the README from being shown (the page would instead show "Oops! That's our fault!" and no README). See #507 (comment) Finally, in exercism/problem-specifications#601 we also realize that symlinks may make it harder for contributors using platforms without symlinks to contribute to this track. Due to all these factors combined, we sadly give up on having symlinks. Closes #442 Closes exercism/DEPRECATED.trackler#13
rbasso
approved these changes
Mar 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442
Details in individual commit messages.
Let me merge this one since it has a "Closes exercism/DEPRECATED.trackler#13" in it and I'm the issue creator so it'll only work if I merge it.