luhn 1.0.0.2: only test isValid, use (most) x-common cases#533
luhn 1.0.0.2: only test isValid, use (most) x-common cases#533petertseng merged 1 commit intoexercism:masterfrom petertseng:luhn
Conversation
|
Say the word if you disagree with the path taken. I don't want to have to do extra work to filter out the invalid inputs only to have to delete the work if exercism/problem-specifications#523 is accepted. |
|
and sorry I hadn't set up hlint on this machine |
|
|
||
| it "create 232320057766355" $ | ||
| create 232320057766355 `shouldBe` 2323200577663554 | ||
| specs = describe "valid" $ for_ cases test |
| -- , Case { description = "valid strings with punctuation included become invalid" | ||
| -- , input = "055-444-285" | ||
| -- , expected = False | ||
| -- } |
There was a problem hiding this comment.
Here it seems that you suppressed one test:
{
"description": "valid strings with symbols included become invalid",
"property": "valid",
"input": "055£ 444$ 285",
"expected": false
},Was it intentional?
I don't consider that a problem, because considering what was discussed in exercism/problem-specifications#428, it probably shouldn't exist anyway.
There was a problem hiding this comment.
Oh! I guess I'll add it (and comment it) for the purpose of following x-common, but you are right that we expect the case to go away soon.
exercism/problem-specifications#474 exercism/problem-specifications#496 exercism/problem-specifications#522 exercism/problem-specifications#547 In consideration of exercism/problem-specifications#523, we will not be testing the malformed inputs. They have been commented out. Closes #469
* bowling 1.0.0.2: drop unneeded rolls, edit a description * leap 1.0.0.2: explain criteria in descriptions, put in progress order * luhn 1.0.0.2: only test isValid, use (most) x-common cases * phone-number 1.2.0.3: enforce area/exchange not starting with 1 * roman-numerals 1.0.0.2: add descriptions
|
Oh interesting. @rbasso could I trouble you to approve this one again? Since I made a change since the previous approval, and this matters if I'm octomerging. Interestingly, the fact that I made changes since the previous approval wouldn't stop me from merging on the web, which actually makes this seem a little inconsistent. |
2 participants
exercism/problem-specifications#474
exercism/problem-specifications#496
exercism/problem-specifications#522
exercism/problem-specifications#547
In consideration of exercism/problem-specifications#523, we
will not be testing the invalid inputs. They have been commented out.
Closes #469