adding isogram by Average-user · Pull Request #595 · exercism/haskell

Average-user · 2017-09-20T05:21:59Z

Another Unimplemented exercise

Average-user · 2017-09-20T05:22:31Z

This one is ok. right?

petertseng · 2017-09-20T06:07:55Z

+      "core": false,
+      "unlocked_by": null,
+      "difficulty": 1,
+      "topics": [


in contrast to Maybe, I don't think this:

affects where we would choose to place the exercise

is necessarily going to be in everyone's solutions

so I would remove it

petertseng · 2017-09-20T06:08:12Z

@@ -0,0 +1,20 @@
+name: isogram
+version: 1.1.0


petertseng · 2017-09-20T06:10:42Z

@@ -0,0 +1,64 @@
+{-# OPTIONS_GHC -fno-warn-type-defaults #-}


given that #144 tells us this line helps for exercises with numbers but this is not one, I think it can be removed?

petertseng · 2017-09-20T06:12:42Z

@@ -0,0 +1,6 @@
+module Isogram (isIsogram) where
+
+import Data.Char


since

Not every solution wants or needs this

I wouldn't want to encourage the habit of importing everything rather than the specific list of functions desired

I would remove this line

petertseng

OK, I don't think there's anything big to change, so it will be merged no more than 48 hours. There are two small things. I was going to do them myself. You can if you want.

petertseng · 2017-09-21T18:37:27Z

+
+## Source
+
+see more  at [wikipedia page of isograms]("https://en.wikipedia.org/wiki/Isogram")


as you can see in https://github.com/Average-user/haskell/blob/d1556eadc748688089e3261700ab9678f2caf245/exercises/isogram/README.md, the quotes mean it is not a link.

I'm going to regenerate this README anyway so it doesn't matter whether you fix this, but don't put quotes in the brackets

ok, so the next time i make PR like this, do i even have to put the README.md?

I guess not! I will just do it. However, it would be good if you just put a README.md that just says "please regenerate this for me" so that I don't forget to!

ok, also, dont merge yet, i want to implement something

petertseng · 2017-09-21T18:38:10Z

@@ -0,0 +1,5 @@
+module Isogram (isIsogram) where
+


I would remove one newline here so there is only one between module and isIsogram, not two.

Average-user · 2017-09-21T22:59:22Z

Now you can merge if you want

Average-user · 2017-09-22T20:03:40Z

How can i do if i want to do another PR before this one gets merge?

petertseng · 2017-09-22T20:26:19Z

How can i do if i want to do another PR before this one gets merge?

Make a branch.

Average-user · 2017-09-22T21:25:03Z

But Github will still catch the differences with the (in this case) Isogram commits

petertseng · 2017-09-22T22:16:16Z

But Github will still catch the differences with the (in this case) Isogram commits

Github shows all commits that are not on the target branch (Exercism's master branch) but are on the PR branch (your new branch). The Isogram commits should not be on your new branch. Achieve that using whatever means you prefer. Ask if you want a suggestion of a preferred means.

Average-user · 2017-09-22T22:28:44Z

Thanks, i'll take that suggestion you offer .

petertseng · 2017-09-22T22:38:42Z

Case 1: You do not already have a branch.

You decide on a branch name, and then you git checkout -b your_new_branch_name 7dc8cf2f0403857a79d13c4916d4b26f99af15e4

(why, because 7dc8cf2f0403857a79d13c4916d4b26f99af15e4 is the latest commit shown on https://github.com/exercism/haskell/commits/master )

Case 2: You already have a branch.

You git checkout your_existing_branch_name if you are not already on that branch, then you git rebase -i 7dc8cf2f0403857a79d13c4916d4b26f99af15e4, then you delete all lines that are related to Isogram.

Average-user · 2017-09-23T00:53:09Z

Instead of this key (or whatever) 7dc8cf2f0403857a79d13c4916d4b26f99af15e4 can I use the link https://github.com/exercism/haskell?

petertseng · 2017-09-23T03:29:16Z

Instead of this key (or whatever) 7dc8cf2f0403857a79d13c4916d4b26f99af15e4 can I use the link https://github.com/exercism/haskell?

If the repository https://github.com/exercism/haskell is a remote on your local copy of the git repo, you may instead use your_name_for_the_exercism_remote/master instead of 7dc8cf2f0403857a79d13c4916d4b26f99af15e4.

petertseng

far as I can tell, we are ready to go.

petertseng · 2017-09-23T04:07:02Z

Thank you for implementing this exercise!

adding isogram

857bc67

fix to isogram example

ac9dd46

petertseng reviewed Sep 20, 2017

View reviewed changes

Average-user added 3 commits September 20, 2017 12:46

isogram:some corrections

ebcd98e

Update config.json

1628957

Test.hs correction

d1556ea

petertseng reviewed Sep 21, 2017

View reviewed changes

Lucas Polymeris added 2 commits September 21, 2017 15:56

Update Isogram.hs

17c7c2f

isogram, algorithm changed

47de491

isogram: regenerate readme

abf6d1e

petertseng approved these changes Sep 23, 2017

View reviewed changes

petertseng merged commit 53a2299 into exercism:master Sep 23, 2017

		@@ -0,0 +1,6 @@
		module Isogram (isIsogram) where

		import Data.Char


		## Source

		see more at [wikipedia page of isograms]("https://en.wikipedia.org/wiki/Isogram")

Uh oh!

Conversation

Average-user commented Sep 20, 2017

Uh oh!

Average-user commented Sep 20, 2017

Uh oh!

petertseng Sep 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petertseng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Average-user commented Sep 21, 2017

Uh oh!

Average-user commented Sep 22, 2017

Uh oh!

petertseng commented Sep 22, 2017

Uh oh!

Average-user commented Sep 22, 2017

Uh oh!

petertseng commented Sep 22, 2017

Uh oh!

Average-user commented Sep 22, 2017

Uh oh!

petertseng commented Sep 22, 2017

Uh oh!

Average-user commented Sep 23, 2017

Uh oh!

petertseng commented Sep 23, 2017

Uh oh!

petertseng left a comment

Choose a reason for hiding this comment

Uh oh!

petertseng commented Sep 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

petertseng Sep 20, 2017 •

edited

Loading