implementing rotational-cipher#604
implementing rotational-cipher#604petertseng merged 5 commits intoexercism:masterfrom Average-user:rotational
Conversation
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
yeah I think most things ar elooking good and this should be an easy merge. but I have serious doubts about that UUID.
| "topics": [ | ||
| ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
I can't help but notice that this has letters outside of a-f, not sure that's acceptable for a UUID. Also need to check #601 (comment).
There was a problem hiding this comment.
Do I make another PR for the complex-numbers UUID, or I include it in here?
There was a problem hiding this comment.
As long as it's in a separate commit, I would take it either way, but I suggest a different PR since I can merge that one quickly and can't merge this one quickly yet.
| @@ -0,0 +1 @@ | |||
| # Regenerate this pls!!! | |||
There was a problem hiding this comment.
I remind myself to regenerate before merging.
| rotate r = map (f r ['a'..'z'] . f r ['A'..'Z']) | ||
| where f x abc e = case elemIndex e abc of | ||
| Nothing -> e | ||
| (Just a) -> abc!!mod (a+x) 26 |
There was a problem hiding this comment.
huh, I didn't think the parentheses around Just a are required, but I don't know
|
generated README, rebased on master, I think that's all we have to do |
|
@petertseng I think so. |
|
Thank you for your fifth exercise. |
2 participants
No description provided.