leap: Improve test suite to cover corner case.

[paulrex]

Currently, the test suite has a loophole where it is possible to pass
all the tests with a function that simply checks if year `mod` 16 == 0.

This commit changes one of the test cases so that is no longer possible.

[petertseng]

Very nice catch.

Please, I need you to send a pull request to https://github.com/exercism/problem-specifications/blob/master/exercises/leap/canonical-data.json, otherwise the Haskell will no longer be in compliance with that file (for good reason, but still not in compliance). And the other reason to do so is so that other tracks can use it. We wouldn't want to be selfish.

[paulrex]

Certainly. exercism/problem-specifications#955

[petertseng]

As you can see, I increased the version to match problem-specifications as well. Minor enough that I didn't want to ask you to do it and make everyone wait for one more cycle, so I just did it.

[petertseng]

Excellent, thank you!

[ioistired]

I just fetched leap and year `mod` 16 == 0 still passes.
What needs to happen so it's updated?

[petertseng]

https://github.com/exercism/trackler/tree/master/tracks directory contains haskell repo. That needs to update, then trackler gem version needs to be published, then https://github.com/exercism/exercism.io/blob/master/Gemfile.lock#L186 needs to use the new trackler version.

[ioistired]

The folder in tracks/ is this repository, so that's done.
Is all that's left to bump the trackler gem version and publish it?

[petertseng]

Right.

2.2.1.46 was released at (sometime around the time when exercism/DEPRECATED.trackler@6c47e10 was made, too lazy to check the actual time)

It was deployed to the website at (notification in exercism/dev channel)

14:58:21 < gitter> Heroku [exercism] deployed fdde061b

[ioistired]

Excellent. Just tested and it's fixed now.