Implementing: isbn-verifier#612
Conversation
| "core": false, | ||
| "unlocked_by": null, | ||
| "difficulty": 1, | ||
| "topics": [ |
There was a problem hiding this comment.
probably make a PR adding strings to all exercises that have it
There was a problem hiding this comment.
It is ok if I make that after this get merged? If that ever happens.
There was a problem hiding this comment.
Yes of course, since doing it after is one of the two possible options:
- remove string from this PR, make string PR after this PR is merged
- make string PR and it is merged before this PR is merged, in which case keeping string here is OK
There was a problem hiding this comment.
I was thinking on doing the first when I removed Strings.
|
I generally think this is good, but I don't like some of the problem-specifications cases so I'm going to get that sorted before merging it here. |
|
@petertseng What do you mean with sorted? How is that gonna change you disliking it? |
|
3-598-2X507-0 should be 3-598-2X507-9, otherwise it doesn't check that X is only valid as a check digit 3-598-21507-XA should be 3-598-21507-XX, otherwise it doesn't check too long ISBN |
|
@petertseng But how is that sorting exactly? |
|
Well, I'm getting it fixed, am I not? |
|
Ok. Should someone do a PR in the original tests cases? |
|
Well it looks like I can merge exercism/problem-specifications#993 soon. |
|
OK exercism/problem-specifications#993 is merged, you can update the test cases now |
|
@petertseng Ok, in a moment |
| @@ -0,0 +1,20 @@ | |||
| name: isbn-verifier | |||
| version: 1.0.0.1 | |||
There was a problem hiding this comment.
Thats because the update ?
There was a problem hiding this comment.
indeed, because that's what https://github.com/exercism/problem-specifications/blob/master/exercises/isbn-verifier/canonical-data.json#L3 says.
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
ISBN verifier should be good to go now
|
thank you for implementing your seventh exercise! |
|
Thanks to you too. Another one some time? |
|
Well, whenever you or anyone else sees fit to implement them. |
2 participants
No description provided.