pythagorean-triplet 1.0.0.3: Test only tripletsWithSum#753
Merged
petertseng merged 2 commits intoexercism:masterfrom Oct 31, 2018
petertseng:pythag
Merged
pythagorean-triplet 1.0.0.3: Test only tripletsWithSum#753petertseng merged 2 commits intoexercism:masterfrom petertseng:pythag
petertseng merged 2 commits intoexercism:masterfrom
petertseng:pythag
Conversation
Replacing previous tests with isPythagorean (don't test intermediate steps) and triplets in factor range (reasonable way to test, just not what the canonical data chose to use) Given the new restriction of `a < b < c` we no longer need `mkTriplet` according to the previous rationale for keeping it (ordering): #507 (comment) exercism/problem-specifications#1332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing previous tests with isPythagorean (don't test intermediate
steps) and triplets in factor range (reasonable way to test, just not
what the canonical data chose to use)
Given the new restriction of
a < b < cwe no longer needmkTripletaccording to the previous rationale for keeping it (ordering):
#507 (comment)
exercism/problem-specifications#1332
exercism/problem-specifications#1365