upgrade pangram tests to 2.0.0#871
upgrade pangram tests to 2.0.0#871sshine merged 2 commits intoexercism:masterfrom chiroptical:pangram_sync
Conversation
|
The thing that is most important is the content. As we can see from The original motivation for the changed descriptions was that descriptions that are too long don't work well for some tracks. This track does not appear to have such a problem, so if there are some description changes that actually lose some information, we can keep them. On the other hand if there are some changes whose purpose is to be better English, I would say to probably apply them to this track as well. "sentence empty" vs "empty sentence" would be in that category, I suppose? |
|
Great, I'll go through and compare the descriptions to see if any make sense to incorporate. |
sshine
left a comment
There was a problem hiding this comment.
@barrymoo: The main difference between #843 and here is that the phrases there are for property-based tests that are not shared with the problem-specifications repo, and the attempt here is to somewhat sync the unit tests. We may have an interest on the Haskell track in slightly deviating from canonical tests when the purpose of shortening a test description does not apply.
Although we use Hspec, we generally don't think much about how test output renders in practice. Perhaps this is because canonical tests don't assume a "readable spec" format with "it" being the initial combinator. Both choices have their pros and cons: With this PR we get better output, but further syncing becomes slightly harder, since the difference must be analysed and the reasoning is found in this PR / commit and not in the test suite itself.
I'm willing to accept these changes on the grounds that the problem-specifications repo is temporarily out of order (exercism/problem-specifications#1560) and will most likely work differently when we get something back that fills its role. In the meantime, we should continue to improve on the Haskell track.
I will wait 48 hours for other maintainers to interject before squash merging this.
This PR updates the
pangramtests original mentioned in #852I found this commit exercism/problem-specifications@f68b632 describing the recent changes to the tests. It seems that the descriptions are the only thing that changed. Is the goal to match the descriptions? Or match the canonical tests described in the specifications?