Create stub template, change POLICIES.md/CONTRIBUTING.md#1723
Create stub template, change POLICIES.md/CONTRIBUTING.md#1723FridaTveit merged 4 commits intoexercism:masterfrom
Conversation
|
See #1721 Before adding the missing stub files, we should agree on the template. |
|
The installation of jdk8 failed, so I had to update the travis config file and close/open the PR to trigger the builds. See #1724. |
lemoncurry
requested review from
FridaTveit and
Smarticles101
and removed request for
FridaTveit
|
(@lemoncurry as a maintainer you should be able to restart the build from here if you sign in with github) |
Thank you! |
Co-Authored-By: Logan Stucki <logan@loganstucki.me>
FridaTveit
left a comment
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great! I only have one minor comment 🙂
| Stubs should include the following body: | ||
| `throw new UnsupportedOperationException("Delete this statement and write your own implementation.");` | ||
| > - Exercises of difficulty 5 or higher: provide a starter file without stubs (StubTemplate.java) and rename it, and either (1) add hints to the hints.md file (which gets merged into the README.md for the exercise) or (2) provide stubs as above for exercises that demand complicated method signatures. | ||
| > - Exercises of difficulty 5 or higher: provide a starter file without stubs (StubTemplate.java file provided [here](https://github.com/exercism/java/tree/master/_template/src/main/java)) and rename it, and either (1) add hints to the hints.md file (which gets merged into the README.md for the exercise) or (2) provide stubs as above for exercises that demand complicated method signatures. |
There was a problem hiding this comment.
Sorry, I think this sentence is still a tiny bit confusing. Reading it I think it's not quite clear if you're meant to copy the provided file or create your own. Something like:
Exercises of difficulty 5 or higher: copy the StubTemplate.java file (provided [here](...)) and rename it, and either ...
might be more clear? 🙂 And maybe a sentence explaining what we'd like it to be renamed to could be useful? E.g. ... and rename it to fit the exercise. For example, for the exercise linked-list the file could be named LinkedList.java. That's probably obvious, but maybe better to add too much information than too little? 🙂
There was a problem hiding this comment.
Yes, that's true, it's better to add more information. I added your suggestions.
FridaTveit
left a comment
FridaTveit
left a comment
There was a problem hiding this comment.
Looks great, thanks @lemoncurry! 😄
3 participants
Reviewer Resources:
Track Policies