resistor-color-trio: create exercise by HuskyNator · Pull Request #1772 · exercism/java

HuskyNator · 2019-10-12T12:46:57Z

Closes #1750

Reviewer Resources:

Track Policies

Implement, with the example using enumeration.

Include resistor-color-trio

HuskyNator · 2019-10-15T20:46:27Z

Not sure why these are conflicts...

lemoncurry · 2019-10-16T07:49:48Z

Not sure why these are conflicts...

It seems that you also added some changes for the Resistor Color Duo exercise, which has already been merged.

#1750)

jmrunkle · 2020-04-12T17:07:16Z

+    private enum Color {
+        black, brown, red, orange, yellow, green, blue, violet, grey, white;
+    };


Java enums should generally be in UPPER_SNAKE_CASE.

I think the API should actually ingest the enum which should be a public file of its own (Color.java).

Does the Java track exercise a policy or a preference wrt. multiple files handed out?

I do not know of a specific policy, but I know that there are exercises which do this: https://github.com/exercism/java/tree/master/exercises/dominoes/src/main/java

There is one reference to multiple file submissions in the POLICIES file though (which implies it is totally fine):

The first exercise in the track whose test suite mandates multiple solution files should be accompanied by a hints.md file reminding the practitioner that the CLI supports multiple file submissions.

jmrunkle · 2020-04-12T17:08:21Z

@@ -0,0 +1,5 @@
+class ResistorColorTrio {
+    String value(String[] colors) {


Suggested change

String value(String[] colors) {

String value(Color... colors) {

This should really take the Color enum as input. It's a good setup for varargs.

From the exercise I thought the idea behind the exercise was applying knowledge about enums. Thus predefining them might defeat the purpose.

Fairly honestly however, I have since almost fully forgotten how exercism works and/or why the entire project is set up like it is. My apologies.

jmrunkle · 2020-04-12T17:10:00Z

+        String[] input = { "orange", "orange", "black" };
+        String expected = "33 ohms";
+        String actual = resistorColorTrio.value(input);


Suggested change

String[] input = { "orange", "orange", "black" };

String expected = "33 ohms";

String actual = resistorColorTrio.value(input);

String expected = "33 ohms";

String actual = resistorColorTrio.value(Color.ORANGE, Color.ORANGE, Color.BLACK);

Same throughout.

jmrunkle · 2020-04-12T17:13:59Z

+        int intValue = (10 * Color.valueOf(colors[0]).ordinal() + Color.valueOf(colors[1]).ordinal())
+                * (int) Math.pow(10, Color.valueOf(colors[2]).ordinal());
+        String stringValue;
+        if (intValue >= 1000) {
+            stringValue = String.valueOf(intValue / 1000) + " kiloohms";
+        } else {
+            stringValue = String.valueOf(intValue) + " ohms";
+        }
+        return stringValue;


The canonical implementation should probably include encoding more information into the Color enum. Might also want to consider another enum for the powers (like OHMS, KILOOHMS, ...). This solution only adds support for kiloohms and we can do better (I know the Kotlin version goes up to something like exaohms).

The Haskell solution only goes to giga, but adds optional edge cases that the original exercise does not address, because functional programmers have an obsession with totality. The point is that while you could extend the range beyond giga, you could also do a lot of other things, or not.

I suppose I am biased by having seen the Kotlin implementation of this exercise. IMO: we should go up to giga specifically since the exercise naturally produces gigaohms.

Keeping it simple and as specific as possible seemed like a good option.
However, as per my other comment, i do not know if this is preferrable or not.

sshine

Thanks for all your reviews, @jmrunkle.

I've responded to a few of them because they popped up in my inbox.

So see my messages as an indicator that your thought progression has made participation easier.

sshine · 2020-04-13T12:18:55Z

+    private enum Color {
+        black, brown, red, orange, yellow, green, blue, violet, grey, white;
+    };


Does the Java track exercise a policy or a preference wrt. multiple files handed out?

sshine · 2020-04-13T12:27:27Z

+        int intValue = (10 * Color.valueOf(colors[0]).ordinal() + Color.valueOf(colors[1]).ordinal())
+                * (int) Math.pow(10, Color.valueOf(colors[2]).ordinal());
+        String stringValue;
+        if (intValue >= 1000) {
+            stringValue = String.valueOf(intValue / 1000) + " kiloohms";
+        } else {
+            stringValue = String.valueOf(intValue) + " ohms";
+        }
+        return stringValue;


The Haskell solution only goes to giga, but adds optional edge cases that the original exercise does not address, because functional programmers have an obsession with totality. The point is that while you could extend the range beyond giga, you could also do a lot of other things, or not.

jmrunkle · 2020-04-26T21:02:27Z

@HuskyNator - are you still working on this PR?

HuskyNator · 2020-04-26T21:05:14Z

Yes sorry, Ive been quite bussy

- upper snake case for enum - typo & simplification in test

HuskyNator added 6 commits October 1, 2019 15:48

Implement Resistor Color Duo

4bc15bf

Implement, with the example using enumeration.

Apply requested changes

dffba74

remove unnecessary javadoc

fd0faa1

Add version file

7752b91

Setup Resistor-Color-Trio

5149cd2

Include resistor-color-trio

Add Test

8b0e461

HuskyNator and others added 3 commits October 19, 2019 12:47

Merge branch 'master' into risistor-color-trio(#1750)

6f0089d

Update Build exception format

b0ea2ce

Merge remote-tracking branch 'upstream/master' into risistor-color-trio(

da5fe12

#1750)

jmrunkle suggested changes Apr 12, 2020

View reviewed changes

sshine changed the title ~~Risistor color trio~~ resistor-color-trio: create exercise Apr 13, 2020

sshine reviewed Apr 13, 2020

View reviewed changes

Resolve some suggestions

417065c

- upper snake case for enum - typo & simplification in test

iHiD closed this Jan 28, 2021

iHiD deleted the branch exercism:master January 28, 2021 19:15

HuskyNator mentioned this pull request Jun 28, 2022

resistor-color-trio: implement exercise #1750

Closed

		@@ -0,0 +1,5 @@
		class ResistorColorTrio {
		String value(String[] colors) {

	String value(String[] colors) {
	String value(Color... colors) {

Uh oh!

Conversation

HuskyNator commented Oct 12, 2019

Closes #1750

Uh oh!

HuskyNator commented Oct 15, 2019

Uh oh!

lemoncurry commented Oct 16, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sshine left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmrunkle commented Apr 26, 2020

Uh oh!

HuskyNator commented Apr 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants