Adding approach to Queen-Attack by jagdish-15 · Pull Request #2860 · exercism/java

jagdish-15 · 2024-11-09T18:53:59Z

pull request

This pull request adds an approach to the Queen-Attack exercise.

I was unsure how to generate a uuid for the approach, so I've left it empty for now. I would greatly appreciate guidance on how to generate one.

Reviewer Resources:

Track Policies

tasxatzial · 2024-11-13T10:44:42Z

@jagdish-15 Have you looked at https://exercism.org/docs/building/configlet/uuid

jagdish-15 · 2024-11-14T17:02:53Z

@tasxatzial, thank you so much for letting me know! I couldn't find it anywhere—I guess I didn't search thoroughly enough in the documentation. But I've now configured the configlet and will be adding the UUID as soon as possible!

tasxatzial · 2024-11-15T06:08:17Z

Just by looking at the general structure of the files, it's probably a good idea to format them with one sentence per line. The maintainer will likely ask for it, see here

jagdish-15 · 2024-11-15T17:54:18Z

@tasxatzial, I've formatted the document as you requested. Thank you for the suggestions! Please let me know if there's anything else I should consider.

tasxatzial · 2024-11-15T18:03:29Z

@jagdish-15 Well, I can do a quick review of the general style (not the code), but I'd prefer to get permission from the maintainer first. Keep in mind that any changes I propose can be overridden by the maintainer, so I'll need to be extra careful with my suggestions to minimize your workload.

@kahgoh let me know if you need any help with this one.

jagdish-15 · 2024-11-15T18:17:45Z

Thanks, @tasxatzial! I appreciate your offer to review the style. I understand that any changes might be overridden by the maintainer, so I’ll leave it to you to proceed carefully.

@kahgoh, please let me know if you have any other feedback or if you'd like me to make any changes.

jagdish-15 · 2024-11-18T19:19:31Z

Hello @kahgoh,

I've updated this to align with all the consistency suggestions you provided for the previous PR here. Please take a look and let me know if there's anything else you'd like me to adjust.

kahgoh · 2024-11-19T14:58:47Z

Thanks @jagdish-15, I've just gotten around to taking a look and posting the comments. Also thanks @tasxatzial for reviewing the style!

Co-authored-by: Kah Goh <villastar@yahoo.com.au>

…content.md Co-authored-by: Kah Goh <villastar@yahoo.com.au>

…ing the content for the same

jagdish-15 · 2024-11-19T17:55:46Z

Hello @kahgoh,

I've renamed the approach to the one you suggested, as it better aligns with the content and the overall approach (thank you for that!). Additionally, I've streamlined the content file by removing several unnecessary sections and making alterations to others. Could you take a look at the changes and let me know what you think?

kahgoh

Thanks! A couple of minor style comments.

kahgoh · 2024-11-21T09:53:13Z

+
+## Explanation
+
+1. **Constructor**:


Is meant to be a sub-heading (###)? If so could you also fix move remove the indenting of the text in the section?

Suggested change

1. **Constructor**:

### Constructor

kahgoh · 2024-11-21T09:53:51Z

+
+   If either of these conditions is true, an exception is thrown.
+
+2. **Method (`canQueensAttackOneAnother`)**:


Similar to above, I think this is a heading? Also suggest rearranging the name to try make it read better.

Suggested change

2. **Method (`canQueensAttackOneAnother`)**:

### `canQueensAttackOneAnother` Method

tasxatzial

I had a review pending, but most of the suggestions have been covered. One last thing i'd like to point out is that there are lots of ifs that are redundant since it's clear that the sentence describes a condition. I'll leave them as suggestions.

@jagdish-15 don't act on them without permission from the maintainer.

tasxatzial · 2024-11-21T22:43:23Z

+   - If either queen is `null`.
+   - If both queens occupy the same position.


Suggested change

- If either queen is `null`.

- If both queens occupy the same position.

- Either queen is `null`.

- Both queens occupy the same position.

tasxatzial · 2024-11-21T22:43:50Z

+   - If the row difference is zero (the queens are on the same row).
+   - If the column difference is zero (the queens are on the same column).
+   - If the row and column differences are equal (the queens are on the same diagonal).


Suggested change

- If the row difference is zero (the queens are on the same row).

- If the column difference is zero (the queens are on the same column).

- If the row and column differences are equal (the queens are on the same diagonal).

- The row difference is zero (the queens are on the same row).

- The column difference is zero (the queens are on the same column).

- The row and column differences are equal (the queens are on the same diagonal).

tasxatzial · 2024-11-21T22:44:17Z

+1. **Same Row**: If the queens are on the same row.
+2. **Same Column**: If the queens are on the same column.
+3. **Same Diagonal**: If the queens are on the same diagonal, i.e., the absolute difference between their row and column positions is equal.


Suggested change

1. **Same Row**: If the queens are on the same row.

2. **Same Column**: If the queens are on the same column.

3. **Same Diagonal**: If the queens are on the same diagonal, i.e., the absolute difference between their row and column positions is equal.

1. **Same Row**: The queens are on the same row.

2. **Same Column**: The queens are on the same column.

3. **Same Diagonal**: The queens are on the same diagonal, i.e., the absolute difference between their row and column positions is equal.

kahgoh · 2024-11-22T13:35:39Z

I had a review pending, but most of the suggestions have been covered. One last thing i'd like to point out is that there are lots of ifs that are redundant since it's clear that the sentence describes a condition. I'll leave them as suggestions.

@jagdish-15 don't act on them without permission from the maintainer.

The suggestions look fine to me.

…h-15/java into add-approach-queen-attack Merging with remote

jagdish-15 · 2024-11-23T14:54:54Z

Thank you so much, @tasxatzial and @kahgoh, for your valuable feedback! I truly appreciate it and have updated the content based on all your suggestions. Apologies for the delay in getting back to you!

kahgoh

Looks good now! Thanks!

jagdish-15 added 3 commits November 10, 2024 00:21

Adding approache to Queen-Attack

303523e

Fixing style errors

80c4de0

Fixing style errors

db87438

jagdish-15 added 5 commits November 14, 2024 23:20

Adding uuid for approach of queen-attack exercise

e0f7eb5

Adding approache to Queen-Attack

2d683d8

Fixing style errors

d19f7bf

Fixing style errors

418ddb5

Adding uuid for approach of queen-attack exercise

c8acf18

jagdish-15 force-pushed the add-approach-queen-attack branch from e0f7eb5 to c8acf18 Compare November 14, 2024 18:01

jagdish-15 added 3 commits November 15, 2024 23:14

Fixing minor issues

dd94b36

Merging with latest changes

3c4e52d

Fixing styling issues

31ace8a

Chnaging the introduction.md for consistancy

5885dc8

kahgoh reviewed Nov 19, 2024

View reviewed changes

kahgoh changed the title ~~Adding approache to Queen-Attack~~ Adding approach to Queen-Attack Nov 19, 2024

jagdish-15 and others added 5 commits November 19, 2024 22:23

Update exercises/practice/queen-attack/.approaches/introduction.md

ddea7e4

Co-authored-by: Kah Goh <villastar@yahoo.com.au>

Update exercises/practice/queen-attack/.approaches/introduction.md

ec9e1e2

Co-authored-by: Kah Goh <villastar@yahoo.com.au>

Update exercises/practice/queen-attack/.approaches/simple-comparison/…

a4d7438

…content.md Co-authored-by: Kah Goh <villastar@yahoo.com.au>

Changing the name of the approach for queen-attack exercise and updat…

d4f1b8e

…ing the content for the same

Updating introduction for approaches of queen-attack

3340b82

kahgoh reviewed Nov 21, 2024

View reviewed changes

tasxatzial reviewed Nov 21, 2024

View reviewed changes

jagdish-15 added 3 commits November 23, 2024 20:06

Merge branch 'main' into add-approach-queen-attack

0715df7

Updating the approach for queen-attack after feedback

7f4e980

Merge branch 'add-approach-queen-attack' of https://github.com/jagdis…

b665c33

…h-15/java into add-approach-queen-attack Merging with remote

kahgoh approved these changes Nov 24, 2024

View reviewed changes

kahgoh merged commit 5e5d444 into exercism:main Nov 24, 2024

jagdish-15 deleted the add-approach-queen-attack branch November 26, 2024 17:41


		If either of these conditions is true, an exception is thrown.

		2. Method (`canQueensAttackOneAnother`):

	2. Method (`canQueensAttackOneAnother`):
	### `canQueensAttackOneAnother` Method

		- If either queen is `null`.
		- If both queens occupy the same position.

Uh oh!

Conversation

jagdish-15 commented Nov 9, 2024

pull request

Uh oh!

tasxatzial commented Nov 13, 2024

Uh oh!

jagdish-15 commented Nov 14, 2024

Uh oh!

tasxatzial commented Nov 15, 2024

Uh oh!

jagdish-15 commented Nov 15, 2024

Uh oh!

tasxatzial commented Nov 15, 2024

Uh oh!

jagdish-15 commented Nov 15, 2024

Uh oh!

jagdish-15 commented Nov 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kahgoh commented Nov 19, 2024

Uh oh!

jagdish-15 commented Nov 19, 2024

Uh oh!

kahgoh left a comment

Choose a reason for hiding this comment

Uh oh!

kahgoh Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

kahgoh Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

tasxatzial left a comment

Choose a reason for hiding this comment

Uh oh!

tasxatzial Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

tasxatzial Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

tasxatzial Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

kahgoh commented Nov 22, 2024

Uh oh!

jagdish-15 commented Nov 23, 2024

Uh oh!

kahgoh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants