Skip to content

[connect] Sync missing test cases#3108

Merged
kahgoh merged 4 commits intoexercism:mainfrom
thibault2705:sync_connect_tests
May 1, 2026
Merged

[connect] Sync missing test cases#3108
kahgoh merged 4 commits intoexercism:mainfrom
thibault2705:sync_connect_tests

Conversation

@thibault2705
Copy link
Copy Markdown
Contributor

pull request

Sync the connect exercise by adding the following missing test cases:
CleanShot 2026-04-22 at 12 40 31@2x

This PR partially solves issue #2959


Reviewer Resources:

Track Policies

@github-actions
Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kahgoh
Copy link
Copy Markdown
Member

kahgoh commented Apr 24, 2026

There are Checkstyle errors. Could you please look into them?

[29](https://github.com/exercism/java/actions/runs/24846500338/job/72808756337?pr=3108#step:4:730)
Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:166:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]

Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:167:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]
Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:168:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]
Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:169:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]
Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:188:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]
Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:189:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]
Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:190:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]
Error: eckstyle] [ERROR] /home/runner/work/java/java/exercises/practice/connect/src/test/java/ConnectTest.java:191:17: 'array initialization' child has incorrect indentation level 16, expected level should be 12. [Indentation]

@kahgoh kahgoh self-requested a review April 24, 2026 22:10
Copy link
Copy Markdown
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the indenting!

@kahgoh kahgoh merged commit 0f5f099 into exercism:main May 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants