Skip to content

nucleotide-count: Remove special treatment of uracil #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sit merged 1 commit into from
Aug 22, 2014
Merged

nucleotide-count: Remove special treatment of uracil #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nucleotide-count/example.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public int count(char base) {
}

private static boolean isCountable(char base) {
final String COUNTABLE_NUCLEOTIDES = "ACGTU";
final String COUNTABLE_NUCLEOTIDES = "ACGT";
return COUNTABLE_NUCLEOTIDES.indexOf(base) == -1;
}

Expand Down
10 changes: 2 additions & 8 deletions nucleotide-count/src/test/java/NucleotideTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,9 @@ public void testCountsANucleotideOnlyOnce() {
}

@Test
public void testDnaHasNoUracil() {
DNA dna = new DNA("CGATTGGG");
assertThat(dna.count('U')).isEqualTo(0);
}

@Test
public void testDnaCountsDoNotChangeAfterCountingUracil() {
public void testDnaCountsDoNotChangeAfterCountingAdenosine() {
DNA dna = new DNA("GATTACA");
dna.count('U');
dna.count('A');
assertThat(dna.nucleotideCounts()).hasSize(4).contains(
entry('A', 3),
entry('C', 1),
Expand Down