Skip to content

[V3] Lucian's Lucious Lasagna: fix everything around this exercise #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SleeplessByte merged 15 commits into from
Mar 2, 2021
Merged

[V3] Lucian's Lucious Lasagna: fix everything around this exercise #1018

SleeplessByte merged 15 commits into from
Mar 2, 2021

Conversation

@SleeplessByte
Copy link
Member

@SleeplessByte SleeplessByte commented Feb 28, 2021 •
edited
Loading

Reviewers, please spell/grammar check

Related #1017

Changes

  • Rename from concept based exercise (basics) to story based exercise lasagna
  • Add full name to config.json
  • Add blurb for basics to config.json
  • Add a big welcome block to the stub
  • Add design document
  • Sync concept documents with exercise documents
  • Change concept link names to be descriptive
  • Remove duplicate concept links

@SleeplessByte SleeplessByte added bug 🐛 Something isn't working enhancement 🦄 Changing current behaviour, enhancing what's already there documentation 📖 Documentation changes chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. v3-migration 🤖 Preparing for Exercism v3 labels Feb 28, 2021
@SleeplessByte SleeplessByte self-assigned this Feb 28, 2021
@SleeplessByte SleeplessByte mentioned this pull request Feb 28, 2021
Closed
10 tasks
@SleeplessByte SleeplessByte requested a review from a team February 28, 2021 21:35
neenjaw
neenjaw approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look awesome. Really like the intro blurbs and the > 💡 quotes

@SleeplessByte SleeplessByte changed the title [V3] lasgana: fix everything around lasgana [V3] lasagna: fix everything around lasagna Feb 28, 2021
@SleeplessByte SleeplessByte changed the title [V3] lasagna: fix everything around lasagna [V3] Lucian's Lucious Lasagna: fix everything around this exercise Feb 28, 2021
ErikSchierboom
ErikSchierboom approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ErikSchierboom
ErikSchierboom reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While reviewing https://github.com/exercism/javascript/pull/1021/files#, I checked the hints.md file of this exercise. It looks like the link to the arithmetic operators no longer refers to the right section, which is probably due to a change in the URL structure as MDN.

Old url: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators
New url: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators#arithmetic_operators

It might be worth updating the URL for the hints.

@SleeplessByte
Copy link
Member Author

SleeplessByte commented Mar 2, 2021

@ErikSchierboom I think MDN didn't get the notion that https://www.w3.org/Provider/Style/URI.html

@SleeplessByte SleeplessByte merged commit 8fc4edd into main Mar 2, 2021
@SleeplessByte SleeplessByte deleted the chore/rename-basics branch March 2, 2021 23:33
This was referenced Jul 14, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

+1 more reviewer

@neenjaw neenjaw neenjaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SleeplessByte SleeplessByte

Labels

bug 🐛 Something isn't working chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. documentation 📖 Documentation changes enhancement 🦄 Changing current behaviour, enhancing what's already there v3-migration 🤖 Preparing for Exercism v3 x:size/large Large amount of work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SleeplessByte @ErikSchierboom @neenjaw