Implement exercise isbn-verifier#366
Merged
matthewmorgan merged 1 commit intoexercism:masterfrom Oct 28, 2017
Merged
Conversation
matthewmorgan
approved these changes
Oct 27, 2017
Contributor
matthewmorgan
left a comment
matthewmorgan
left a comment
There was a problem hiding this comment.
@MattH-be Looks great! One suggestion (not mandatory) and one question for you.
| isValid() { | ||
| if (!this.isbn.match(/^(\d{9}[\dxX])$/)) return false; | ||
|
|
||
| const digits = this.isbn.split(''); |
Contributor
There was a problem hiding this comment.
Perhaps use the ES6 spread operator:
const digits = [...this.isbn];
Contributor
Author
There was a problem hiding this comment.
Changed in a commit. Using the spread operator is indeed the correct syntax in this instance.
| test('valid isbn number', () => { | ||
| const isbn = new ISBN('3-598-21508-8'); | ||
|
|
||
| expect(isbn.isValid()).toBeTruthy(); |
Contributor
There was a problem hiding this comment.
Why '.toBeTruthy()' instead of .toEqual(true)? Did you want to leave the tests open to someone returning something other than a boolean true? Just curious...
Contributor
Author
There was a problem hiding this comment.
You're correct. In this case we only want to get true or false, so I've changed it to all use .toEqual
Contributor
|
Nice job-- all the canonical tests are covered and the PR otherwise looks great. One last thing-- would you mind squashing your commits to one? If you need any hep with this, please let me know, I'd be happy to help. |
Contributor
Author
|
That should've done it. |
Contributor
|
Nice work! Thanks again 🥇 |
MattH-be
added a commit
to MattH-be/ecmascript
that referenced
this pull request
Oct 30, 2017
Grouped all tests under a single describe Ordered the tests in a more logical way. All tests except the first one are skipped. Removed mention of enabling tests by changing xdescribe to describe. Implement exercise isbn-verifier (exercism#366) [Housekeeping] Upgrade jest (exercism#368) * Use `package-lock.json` instead of `yarn.lock` * Upgrade jest and babel-jest to latest versions Jest to 21.2.1 babel-jest to 21.2.0 Change Exercise is now ECMAScript ready (exercism#362) Transpose Exercise is ECMAScript ready (exercism#364) Upgrade jest Protein Translation is ECMAScript ready (exercism#365) (exercism#365) Update setup links in all READMEs (exercism#371) Update all setup links in exercise READMEs from http://exercism.io/languages/ecmascript to http://exercism.io/languages/ecmascript/installation Closes exercism#370 Updated setup link
MattH-be
added a commit
to MattH-be/ecmascript
that referenced
this pull request
Oct 31, 2017
Grouped all tests under a single describe Ordered the tests in a more logical way. All tests except the first one are skipped. Removed mention of enabling tests by changing xdescribe to describe. Implement exercise isbn-verifier (exercism#366) [Housekeeping] Upgrade jest (exercism#368) * Use `package-lock.json` instead of `yarn.lock` * Upgrade jest and babel-jest to latest versions Jest to 21.2.1 babel-jest to 21.2.0 Change Exercise is now ECMAScript ready (exercism#362) Transpose Exercise is ECMAScript ready (exercism#364) Upgrade jest Protein Translation is ECMAScript ready (exercism#365) (exercism#365) Update setup links in all READMEs (exercism#371) Update all setup links in exercise READMEs from http://exercism.io/languages/ecmascript to http://exercism.io/languages/ecmascript/installation Closes exercism#370 Updated setup link
matthewmorgan
pushed a commit
that referenced
this pull request
Oct 31, 2017
Grouped all tests under a single describe Ordered the tests in a more logical way. All tests except the first one are skipped. Removed mention of enabling tests by changing xdescribe to describe. Implement exercise isbn-verifier (#366) [Housekeeping] Upgrade jest (#368) * Use `package-lock.json` instead of `yarn.lock` * Upgrade jest and babel-jest to latest versions Jest to 21.2.1 babel-jest to 21.2.0 Change Exercise is now ECMAScript ready (#362) Transpose Exercise is ECMAScript ready (#364) Upgrade jest Protein Translation is ECMAScript ready (#365) (#365) Update setup links in all READMEs (#371) Update all setup links in exercise READMEs from http://exercism.io/languages/ecmascript to http://exercism.io/languages/ecmascript/installation Closes #370 Updated setup link
laurmurclar
pushed a commit
to laurmurclar/ecmascript
that referenced
this pull request
Nov 4, 2017
laurmurclar
pushed a commit
to laurmurclar/ecmascript
that referenced
this pull request
Nov 4, 2017
Grouped all tests under a single describe Ordered the tests in a more logical way. All tests except the first one are skipped. Removed mention of enabling tests by changing xdescribe to describe. Implement exercise isbn-verifier (exercism#366) [Housekeeping] Upgrade jest (exercism#368) * Use `package-lock.json` instead of `yarn.lock` * Upgrade jest and babel-jest to latest versions Jest to 21.2.1 babel-jest to 21.2.0 Change Exercise is now ECMAScript ready (exercism#362) Transpose Exercise is ECMAScript ready (exercism#364) Upgrade jest Protein Translation is ECMAScript ready (exercism#365) (exercism#365) Update setup links in all READMEs (exercism#371) Update all setup links in exercise READMEs from http://exercism.io/languages/ecmascript to http://exercism.io/languages/ecmascript/installation Closes exercism#370 Updated setup link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.