Transpose Exercise Fixed#379
Merged
rchavarria merged 1 commit intoexercism:masterfrom Nov 7, 2017
Merged
Conversation
rchavarria
suggested changes
Nov 6, 2017
Contributor
rchavarria
left a comment
rchavarria
left a comment
There was a problem hiding this comment.
Thanks for adding a new exercise to the track. I have a small comment about how specs would be read by users.
On each test or xtest block, the provided description starts with test .
I think it's not necessary. When running the tests, without starting with test, users will read the tests output this way:
Transpose empty string
Transpose two characters in a row
Transpose comes from the first describe. If specs start with test, they would read:
Transpose test empty string
It feels less natural, doesn't it?
RobinCsl
force-pushed
the
transpose-fix
branch
from
eff502a to
50d3ae7
Compare
Contributor
Author
|
Hopefully it is how you would like it to be now :) |
RobinCsl
force-pushed
the
transpose-fix
branch
from
50d3ae7 to
02427ec
Compare
rchavarria
approved these changes
Nov 7, 2017
Contributor
|
Absolutely! Thanks a lot for this new exercise 🎉 |
Contributor
|
Nice work @RobinCsl! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @shybyte's solution.