Convert scripts to ES6#687
Conversation
SleeplessByte
left a comment
There was a problem hiding this comment.
- function prepareAndRun(command, infoStr, failureStr) {
+ const prepareAndRun = (command, infoStr, failureStr) => {Any reason you changed from function declaration to "assignment pattern" + arrow function expression? I know it's mostly a stylistic choice, but I think the explicit function reads better 🥇
Also, if you're not re-assigning variables, can you use const instead of let?
❤️ for this PR!
Nothing specific. My personal preference of the shiny arrow function over normal
Makes sense. 👍 |
|
I don't mind the |
Use @babel/node to run them.
|
@SleeplessByte Fixed. |
|
I think this means we can now do #628 ? |
|
@SleeplessByte Yup! #688 |
Use @babel/node to run them.
Also fix comments in scripts.