Fail if there are 26 letters case sensitive#236
Merged
cmcaine merged 1 commit intoexercism:masterfrom May 25, 2020
Merged
Conversation
Contributor
Author
|
Oh I think I should update it here: |
Contributor
|
Thanks! |
Contributor
|
Also merged this: exercism/problem-specifications#1658 But we don't have a script to automatically generate the tests from that (for this exercise), so they also have to be added manually. |
Contributor
Author
|
Ah okay in that case it should be added to the notebook as well, right? |
Contributor
|
Yup, also done in #237 |
Contributor
|
There's a script you can run for it: julia bin/generate-notebooks.jl If you speak the magic words, a github action will do it for you, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I received one solution where it was only checked whether there are exactly 26 letters (case sensitive)
This would result in that
a...m A...Mis a pangram for example.Also fails if there are more than 26 letters when counting i.e o and O as two different ones.