Skip to content

nucleotide-count: Remove special treatment of uracil #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarti merged 1 commit into from
Aug 19, 2014
Merged

nucleotide-count: Remove special treatment of uracil #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions nucleotide-count/example.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ local DNA = {}
function DNA:new(str)
self.__index = self
local nc = { A = 0, T = 0, C = 0, G = 0}
local n = { 'A','T','C','G','U'}
local n = { 'A','T','C','G'}
for i =1,str:len() do
local c = str:sub(i,i)
nc[c]= nc[c] + 1
Expand All @@ -12,15 +12,10 @@ function DNA:new(str)
end

function DNA:count(symbol)
if ( self.nucleotideCounts[symbol] ) then
if ( self.nucleotideCounts[symbol] ) then
return self.nucleotideCounts[symbol]
end
for _,v in pairs(self.NUCLEOTIDES) do
if v == symbol then
return 0
end
end
return error("Invalid Nucleotide")
end

return DNA
return DNA
9 changes: 1 addition & 8 deletions nucleotide-count/nucleotide-count_test.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
local DNA = require('nucleotide-count')

describe('DNA', function()
describe('DNA', function()

it('has no nucleotides', function()
local expected = { A = 0, T = 0, C = 0, G = 0 }
Expand Down Expand Up @@ -44,13 +44,6 @@ describe('DNA', function()
assert.are.same(expected,result)
end)

it('has no uracil', function()
local dna = DNA:new('GGTTGG')
expected = 0
result = dna:count('U')
assert.are.same(expected,result)
end)

it('validates nucleotides', function()
local dna = DNA:new('GGTTGG')
assert.has.errors(function() dna:count('X') end)
Expand Down