implement binary-search-tree exercise#370
Conversation
sshine
left a comment
sshine
left a comment
There was a problem hiding this comment.
Excellent work!
What you have provided appears mergeable without significant modification.
We have a test generator for auto-generating the unit tests, but it has had an overhaul recently that doesn't appear to be documented yet. If you would like, you can see e.g. 37d3e38 (in particular the files affected in test-generator/) for how to extend the generator for a specific test. Since many results in this exercise are trees, this would involve deriving a tree from a JSON object structure, so the work isn't trivial. This part is entirely optional and could also be made as a separate, subsequent PR.
| let rec to_list = function | ||
| | Leaf -> [] | ||
| | Node(l, v, r) -> to_list(l) @ [v] @ to_list(r) No newline at end of file |
There was a problem hiding this comment.
One might consider a tail-recursive variant to avoid stack overflows.
This is also fine, and is what I expect most students would submit.
Co-Authored-By: Simon Shine <shreddedglory@gmail.com>
sshine
left a comment
sshine
left a comment
There was a problem hiding this comment.
It appears that the canonical version for binary-search-tree is 1.0.0, not 1.3.0.
For future self-reference: Include exercism/problem-specifications#940 when squash-merging.
2 participants
No description provided.