Support user output again#109
Merged
mk-mxp merged 6 commits intoexercism:mainfrom May 4, 2024
Merged
Conversation
- User input is not logged in JUnit log anymore - There is no way to make JUnit logs with the output (--fail-on-risky is not accounted for!) - To get the output logged in teamcity logger, the test must fail (--disallow-test-output --fail-on-risky) - Use the teamcity log to add output to tests from JUnit log
mk-mxp
added
x:action/fix
Contributor
|
For this I wanted to create a phpunit extension that would hook itself on phpunit and could do anything we want. I feel like the current setup with junit export and parsing is quite "hacky". |
Contributor
Author
|
JetBrains TeamCity message escaping found. There is no Unicode escaping done in PHPUnit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried a lot of things to make PHPUnit render user output into JUnit logs. I then found out, that this is intentionally removed. So I looked for another way to get the output.
The output is contained in teamcity logs, with additional commandline settings. So I used this to add the output to the result.
Also added tests for the various conditions.
Closes #108