Updates Hello-World exercise skeleton and test spec.#154
Merged
petemcfarlane merged 1 commit intoexercism:masterfrom Apr 23, 2017
Merged
Updates Hello-World exercise skeleton and test spec.#154petemcfarlane merged 1 commit intoexercism:masterfrom
petemcfarlane merged 1 commit intoexercism:masterfrom
Conversation
The Hello-World exercise has fallen out of date with the updated Hello-World description specified in the x-common definition. Update the test and skeleton to reflect this.
|
Looks great! |
camilopayan
pushed a commit
to camilopayan/exercism-php
that referenced
this pull request
Oct 12, 2018
The Hello-World exercise has fallen out of date with the updated Hello-World description specified in the x-common definition. Update the test and skeleton to reflect this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hello-World exercise has fallen out of date with the updated Hello-World description specified in the x-common definition.
The PR that updates the spec is here: exercism/problem-specifications#544
This led to an issue where the Readme for the 'Hello-World' exercise was telling the user to do one thing, but the test suite was expecting another.
This PR update the test and skeleton to remedy the disparity.