Skip to content

Upgrade PHP version on Travis#196

Merged
petemcfarlane merged 3 commits intomasterfrom
kytrinyx/ci-php-version
Feb 5, 2018
Merged

Upgrade PHP version on Travis#196
petemcfarlane merged 3 commits intomasterfrom
kytrinyx/ci-php-version

Conversation

@kytrinyx
Copy link
Copy Markdown
Member

@kytrinyx kytrinyx commented Feb 4, 2018

The build on Travis is failing because the phptest.phar that gets downloaded is incompatible with the version of PHP that we've specified in the .travis.yml file.

PHPUnit 7.0.0 by Sebastian Bergmann and contributors.
This version of PHPUnit is supported on PHP 7.1 and PHP 7.2.
You are using PHP 7.0.25 (/home/travis/.phpenv/versions/7.0.25/bin/php).
make[1]: *** [test-assignment] Error 1

@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 4, 2018

This passes on Travis, but runs with warnings in meetup and series:

Warning: The use statement with non-compound name 'DateTime' has no effect in /tmp/meetup.6BZBp1kvsu/meetup_test.php on line 5

Warning: The use statement with non-compound name 'DateTime' has no effect in /tmp/meetup.6BZBp1kvsu/meetup.php on line 3

Warning: The use statement with non-compound name 'Exception' has no effect in /tmp/series.NmEAIpwb5W/series_test.php on line 3

Warning: The use statement with non-compound name 'Exception' has no effect in /tmp/series.NmEAIpwb5W/series.php on line 3

@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 4, 2018

Ok, I've updated the exercises to remove the warnings on make test.

@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 4, 2018

While I'm at it I'm going to see if we can upgrade to 7.2.

@kytrinyx kytrinyx force-pushed the kytrinyx/ci-php-version branch from 6499b0a to 088ff9c Compare February 4, 2018 17:49
@kytrinyx
Copy link
Copy Markdown
Member Author

kytrinyx commented Feb 4, 2018

Ok, that didn't work, as calling assert() with strings is deprecated. I'm backing out the 7.2 change, but will open an issue about it.

This should be good to go.

@petemcfarlane petemcfarlane merged commit e3b97ec into master Feb 5, 2018
@petemcfarlane petemcfarlane deleted the kytrinyx/ci-php-version branch February 5, 2018 13:16
camilopayan pushed a commit to camilopayan/exercism-php that referenced this pull request Oct 12, 2018
* Upgrade PHP version on Travis to 7.1

* meetup: Delete unnecessary 'use' statement for DateTime

* series: Delete unnecessary 'use' statement for Exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants